[ircd-ratbox] Re: [PATCH] ratbox-services: refine VOICE management

Ralf S. Engelschall rse at engelschall.com
Tue May 3 09:42:32 UTC 2005


On Tue, May 03, 2005, Lee H wrote:

> On Mon, May 02, 2005 at 03:46:32PM +0200, Ralf S. Engelschall wrote:
> > Experience over the last weeks on irc.openpkg.net with the latest
> > Ratbox-Services CVS snapshots (as of 200504XX) showed that the recently
> > introduced NOVOICES feature should be even further refined by splitting
> > it into a REFUSEVOICES (still allowing manual operator voice granting)
> > and a SHUTUPVOICES (enforcing no voice at all).
> >
> > The SHUTUPVOICES is exactly the already implemented NOVOICES (just
> > renamed to avoid those confusing double negations as in "NOVOICES OFF")
> > and covers the REFUSEVOICES, too. The REFUSEVOICES now only controls the
> > VOICE request and AUTOVOICE handling in ChanServ and this way allows
> > operators to still assign VOICE to users manually.
> >
> > The appended patch now finally allows a moderated IRC channel to be used
> > very similar to a real-world moderated conference.
>
> I'm not gunna rename NOVOICES -- it needs to be consistent with NOOPS, and
> whichever way you do it its always going to have a problem with a double
> negative.  I think its explained clearly enough in the SET help.

That's ok for me, of course. It was just a suggestion.

> I've added CHANSERV::SET::NOVOICECMD which will disable use of the VOICE
> command though.

Thanks.

Just one minor issue left. There is a small change you lost from my
patch: an added "%s" in the displaying of flags because of the added
extra NOVOICECMD flag.

Yours,
                                       Ralf S. Engelschall
                                       rse at engelschall.com
                                       www.engelschall.com

Index: src/s_chanserv.c
===================================================================
RCS file: /cvsroot/rserv/src/s_chanserv.c,v
retrieving revision 1.75
diff -u -d -u -d -r1.75 s_chanserv.c
--- src/s_chanserv.c	2 May 2005 22:57:36 -0000	1.75
+++ src/s_chanserv.c	3 May 2005 09:35:35 -0000
@@ -2914,7 +2914,7 @@

 	if(chreg_p->flags & CS_FLAGS_SHOW)
 		service_send(chanserv_p, client_p, conn_p,
-			"[%s] Settings: %s%s%s%s%s",
+			"[%s] Settings: %s%s%s%s%s%s",
 			chreg_p->name,
 			(chreg_p->flags & CS_FLAGS_AUTOJOIN) ? "AUTOJOIN " : "",
 			(chreg_p->flags & CS_FLAGS_NOOPS) ? "NOOPS " : "",



More information about the ircd-ratbox mailing list