[ircd-ratbox] ratbox-services nickserv patch

Ralf S. Engelschall rse at engelschall.com
Sun Apr 17 16:24:26 UTC 2005


On Sun, Apr 17, 2005, Lee H wrote:

> On Sun, Apr 17, 2005 at 03:22:48PM +0200, Ralf S. Engelschall wrote:
> > I felt free and just adding a few lines I assumed to be missing there
> > (see patch below) and now it works fine -- at least for me. I have not
> > reviewed the NickServ implementation in detail and perhaps I'm missing
> > something important and so it is totally bogus what I've done. Then
> > please ignore my patch and correct the storage of nicknames in the
> > proper way. But perhaps this part of the implementation was really
> > just missing and I'm right with my patch, then please take it over and
> > release a new Ratbox-Services version soon. Thanks.
>
> This was a bug, which ive now fixed in CVS.
>
> Your patch was a nice try -- but add_nick_reg() is called when we load from
> the db itself, so youd end up duplicating entries inside the DB - it needed
> to be in nickserv::register.

Ah, I see. Yes, this why I said I'm certainly missing the "big picture"
here because I've not really tried to understand the control flow and
just tried a quick hack. Thanks for fixing this such fast and the
correct way now.

BTW, there is a small additional buglet I had to fix in the OpenPKG
package to get the NickServ help files installed:

Index: ratbox-services/help/Makefile.in
--- ratbox-services/help/Makefile.in.orig   2005-01-04 21:01:20 +0100
+++ ratbox-services/help/Makefile.in    2005-04-13 15:30:42 +0200
@@ -6,7 +6,7 @@
 INSTALL_DATA=@INSTALL_DATA@
 PREFIX=@prefix@

-SUBDIRS=alis main operbot chanserv userserv jupeserv operserv
+SUBDIRS=alis main operbot chanserv userserv jupeserv operserv nickserv

 install:
    $(INSTALL) -m 750 -d $(PREFIX)/help

T
                                       Ralf S. Engelschall
                                       rse at engelschall.com
                                       www.engelschall.com



More information about the ircd-ratbox mailing list